[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f3468f5b-3e0a-ee4a-7e7a-734ed23fbdfa@linux.intel.com>
Date: Fri, 26 Jul 2019 08:33:06 -0500
From: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To: Bard liao <yung-chuan.liao@...ux.intel.com>,
alsa-devel@...a-project.org
Cc: tiwai@...e.de, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org, vkoul@...nel.org, broonie@...nel.org,
srinivas.kandagatla@...aro.org, jank@...ence.com,
slawomir.blauciak@...el.com, Sanyog Kale <sanyog.r.kale@...el.com>
Subject: Re: [alsa-devel] [RFC PATCH 09/40] soundwire: cadence_master: fix
usage of CONFIG_UPDATE
>> @@ -758,15 +774,9 @@ static int _cdns_enable_interrupt(struct sdw_cdns
>> *cdns)
>> */
>> int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns)
>> {
>> - int ret;
>> -
>> _cdns_enable_interrupt(cdns);
>> - ret = cdns_clear_bit(cdns, CDNS_MCP_CONFIG_UPDATE,
>> - CDNS_MCP_CONFIG_UPDATE_BIT);
>> - if (ret < 0)
>> - dev_err(cdns->dev, "Config update timedout\n");
>> - return ret;
> Should we add cdns_update_config() here?
indeed, this would be a good improvement. The code works because we
added the exit_reset() sequence which does call cdns_update_config(),
but better make this function self-contained. When we enable the
clock-stop mode we will not do this reset sequence.
Powered by blists - more mailing lists