linux-kernel - Re: [PATCHv2] hda: Fix 1-minute detection delay when i915 module is not available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr26cq95a.wl-tiwai@suse.de>
Date:   Sat, 27 Jul 2019 08:33:21 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Samuel Thibault <samuel.thibault@...-lyon.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        <931507@...s.debian.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv2] hda: Fix 1-minute detection delay when i915 module is not available

On Fri, 26 Jul 2019 23:47:02 +0200,
Samuel Thibault wrote:
> 
> Distribution installation images such as Debian include different sets
> of modules which can be downloaded dynamically.  Such images may notably
> include the hda sound modules but not the i915 DRM module, even if the
> latter was enabled at build time, as reported on
> https://bugs.debian.org/931507
> 
> In such a case hdac_i915 would be linked in and try to load the i915
> module, fail since it is not there, but still wait for a whole minute
> before giving up binding with it.
> 
> This fixes such as case by only waiting for the binding if the module
> was properly loaded (or module support is disabled, in which case i915
> is already compiled-in anyway).
> 
> Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>

Applied with a slight coding style fix in my side.  Also added Fixes
and Cc-to-stable tags.

At the next time, please check the patch before submission via
checkpatch.pl.


Thanks!

Takashi