linux-kernel - Re: [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fb53b082-4d83-83a6-1ae6-b9fae9dc750f@gmail.com>
Date:   Sat, 27 Jul 2019 14:01:26 +0200
From:   Maximilian Luz <luzmaximilian@...il.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        platform-driver-x86@...r.kernel.org,
        Hans de Goede <hdegoede@...hat.com>,
        Chen Yu <yu.c.chen@...el.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: [PATCH v3 2/2] Input: soc_button_array - Add support for newer
 surface devices

On 7/27/19 11:14 AM, Dmitry Torokhov wrote:
> On Sat, Jul 20, 2019 at 05:05:11PM +0200, Maximilian Luz wrote:
>> -
>> -	error = gpiod_count(dev, NULL);
>> -	if (error < 0) {
>> -		dev_dbg(dev, "no GPIO attached, ignoring...\n");
>> -		return -ENODEV;
> 
> I do not think we need to move this into individual "check" functions.
> It is needed in all cases so we should keep it here.
> 
> How about version below?

Makes sense, looks good to me!

Maximilian