linux-kernel - Re: [PATCH] staging:iio:adc:ad7280a: add of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190727144739.4461b5a3@archlinux>
Date:   Sat, 27 Jul 2019 14:47:39 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Matheus Tavares Bernardino <matheus.bernardino@....br>
Cc:     "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>,
        "Popa, Stefan Serban" <StefanSerban.Popa@...log.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "knaack.h@....de" <knaack.h@....de>,
        "kartik.koolks@...il.com" <kartik.koolks@...il.com>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "kernel-usp@...glegroups.com" <kernel-usp@...glegroups.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH] staging:iio:adc:ad7280a: add of_match_table entry

On Fri, 26 Jul 2019 14:59:16 -0300
Matheus Tavares Bernardino <matheus.bernardino@....br> wrote:

> On Fri, Jul 26, 2019 at 2:30 AM Ardelean, Alexandru
> <alexandru.Ardelean@...log.com> wrote:
> >
> > On Fri, 2019-07-26 at 01:38 +0530, Kartik Kulkarni wrote:  
> > > Add the of_device_id struct and the respective
> > > of_match_device entry to complete device tree support.
> > >  
> >
> > This would be a [V2] I suppose.
> >
> > This change also does the rename of the driver name in a single go.
> > Since it's a trivial change, it's fine from my side.  
> 
> I think there was a small confusion when we sent the patches. Sorry
> for that. Originally, Kartik made the rename in its own patch. Would
> it be better if we resend the two patches separately?
I would prefer that. They are two separate changes, and the driver
name one may be a little unexpected so let's make sure it's obvious.

There is also the question on whether we should tidy up all the
prefixing to make it clear that this is an ad7280a throughout.

Perhaps that's too painful though and we should leave it like this
for now.

Thanks,

Jonathan


> 
> Thanks,
> Matheus
> 
> > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> >
> >  
> > > Signed-off-by: Kartik Kulkarni <kartik.koolks@...il.com>
> > > Reviewed-by: Matheus Tavares <matheus.bernardino@....br>
> > > ---
> > >  drivers/staging/iio/adc/ad7280a.c | 9 ++++++++-
> > >  1 file changed, 8 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> > > index 19a5f244dcae..ded0ba093a28 100644
> > > --- a/drivers/staging/iio/adc/ad7280a.c
> > > +++ b/drivers/staging/iio/adc/ad7280a.c
> > > @@ -1027,9 +1027,16 @@ static const struct spi_device_id ad7280_id[] = {
> > >  };
> > >  MODULE_DEVICE_TABLE(spi, ad7280_id);
> > >
> > > +static const struct of_device_id ad7280_of_match[] = {
> > > +     { .compatible = "adi,ad7280a", },
> > > +     { }
> > > +};
> > > +MODULE_DEVICE_TABLE(of, ad7280_of_match);
> > > +
> > >  static struct spi_driver ad7280_driver = {
> > >       .driver = {
> > > -             .name   = "ad7280",
> > > +             .name   = "ad7280a",
> > > +             .of_match_table = ad7280_of_match,
> > >       },
> > >       .probe          = ad7280_probe,
> > >       .id_table       = ad7280_id,  
> >
> > --
> > You received this message because you are subscribed to the Google Groups "Kernel USP" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-usp+unsubscribe@...glegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/kernel-usp/0e273486f1c4fb6249896225837cdf2da0fd2415.camel%40analog.com.