linux-kernel - Re: [patch] perf.data documentation has wrong units for memory size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 27 Jul 2019 19:15:54 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Vince Weaver <vincent.weaver@...ne.edu>
Cc:     linux-kernel@...r.kernel.org,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>
Subject: Re: [patch] perf.data documentation has wrong units for memory size

On Thu, Jul 25, 2019 at 11:57:43AM -0400, Vince Weaver wrote:
> 
> The perf.data-file-format documentation incorrectly says the 
> HEADER_TOTAL_MEM results are in bytes.  The results are in kilobytes
> (perf reads the value from /proc/meminfo)
> 
> Signed-off-by: Vince Weaver <vincent.weaver@...ne.edu>

Acked-by: Jiri Olsa <jolsa@...nel.org>

thanks,
jirka

> 
> diff --git a/tools/perf/Documentation/perf.data-file-format.txt b/tools/perf/Documentation/perf.data-file-format.txt
> index 5f54feb19977..d030c87ed9f5 100644
> --- a/tools/perf/Documentation/perf.data-file-format.txt
> +++ b/tools/perf/Documentation/perf.data-file-format.txt
> @@ -126,7 +126,7 @@ vendor,family,model,stepping. For example: GenuineIntel,6,69,1
>  
>  	HEADER_TOTAL_MEM = 10,
>  
> -An uint64_t with the total memory in bytes.
> +An uint64_t with the total memory in kilobytes.
>  
>  	HEADER_CMDLINE = 11,
>