linux-kernel - Re: [PATCH AUTOSEL 4.4 17/35] iio: st_accel: fix iio_triggered_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190728154312.GJ8637@sasha-vm>
Date:   Sun, 28 Jul 2019 11:43:12 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
Cc:     "jic23@...nel.org" <jic23@...nel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "denis.ciocca@...com" <denis.ciocca@...com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.4 17/35] iio: st_accel: fix
 iio_triggered_buffer_{pre,post}enable positions

On Mon, Jul 22, 2019 at 06:47:47AM +0000, Ardelean, Alexandru wrote:
>On Sun, 2019-07-21 at 18:23 +0100, Jonathan Cameron wrote:
>> [External]
>>
>> On Fri, 19 Jul 2019 00:14:05 -0400
>> Sasha Levin <sashal@...nel.org> wrote:
>>
>> > From: Alexandru Ardelean <alexandru.ardelean@...log.com>
>> >
>> > [ Upstream commit 05b8bcc96278c9ef927a6f25a98e233e55de42e1 ]
>> >
>> > The iio_triggered_buffer_{predisable,postenable} functions attach/detach
>> > the poll functions.
>> >
>> > For the predisable hook, the disable code should occur before detaching
>> > the poll func, and for the postenable hook, the poll func should be
>> > attached before the enable code.
>> >
>> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
>> > Acked-by: Denis Ciocca <denis.ciocca@...com>
>> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> > Signed-off-by: Sasha Levin <sashal@...nel.org>
>> Hi Sasha,
>>
>> This should do any harm, but I deliberately didn't cc stable on
>> this one.
>>
>> Alex, my assumption on this one is that it was fixing a logical
>> ordering problem, but one that had no visible impact.
>> Whilst the pollfunc will be attached too early, the trigger
>> will be disabled for the whole of this function anyway so
>> it shouldn't cause any visible problem.  Is that a correct interpretation?
>
>Yes.
>That is correct.
>
>Maybe I'll change the commit title format so that there is no confusion.
>It's a fix, but not in the sense that something was broken.
>Just something that is the realm of cleaning up.

I'll drop it from the queue, thanks!

--
Thanks,
Sasha