linux-kernel - Re: [PATCH] Makefile: Globally enable fall-through warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a0e789dd-5244-6af3-56c2-970b03d264a8@embeddedor.com>
Date:   Sun, 28 Jul 2019 11:42:28 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] Makefile: Globally enable fall-through warning

Hi Guenter,

On 7/28/19 8:58 AM, Guenter Roeck wrote:
> On Thu, Jun 06, 2019 at 07:46:17PM -0500, Gustavo A. R. Silva wrote:
>> Now that all the fall-through warnings have been addressed in the
>> kernel, enable the fall-through warning globally.
>>
> 
> Not really "all".
> 
> powerpc:85xx/sbc8548_defconfig:
> 
> arch/powerpc/kernel/align.c: In function ‘emulate_spe’:
> arch/powerpc/kernel/align.c:178:8: error: this statement may fall through
> 
> Plus many more similar errors in the same file.
> 
> All sh builds:
> 
> arch/sh/kernel/disassemble.c: In function 'print_sh_insn':
> arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through
> 
> Again, this is seen in several places.
> 
> mips:cavium_octeon_defconfig:
> 
> arch/mips/cavium-octeon/octeon-usb.c: In function 'dwc3_octeon_clocks_start':
> include/linux/device.h:1499:2: error: this statement may fall through
> 
> None of those are from recent changes. And this is just from my small
> subset of test builds.
> 

Thank you for letting me know about this. I don't have access to build
infrastructure like yours.

My build infrastructure is similar to that of Linus.

But if you send me all of those I can create a patch and send it back
to you to make sure what you see is addressed. If we can coordinate for
this it'd be great for everybody. :)

Thanks
--
Gustavo