linux-kernel - Re: [PATCH v3] gpiolib: Preserve desc->flags when setting state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdags1geSzrLxVGf11PvpH+c_N0F7oa=42C57geKpm2VjQ@mail.gmail.com>
Date:   Mon, 29 Jul 2019 00:58:47 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] gpiolib: Preserve desc->flags when setting state

On Sun, Jul 7, 2019 at 10:36 PM Chris Packham
<chris.packham@...iedtelesis.co.nz> wrote:

> desc->flags may already have values set by of_gpiochip_add() so make
> sure that this isn't undone when setting the initial direction.
>
> Fixes: 3edfb7bd76bd1cba ("gpiolib: Show correct direction from the beginning")
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Patch applied for fixes and tagged for stable.

Thanks for digging into this! Excellent work!

Yours,
Linus Walleij