linux-kernel - Re: [PATCH] Kbuild: Handle PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1907281111570.1791@nanos.tec.linutronix.de>
Date:   Sun, 28 Jul 2019 11:13:44 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Sebastian Sewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] Kbuild: Handle PREEMPT_RT for version string and magic

Masahiro,

On Sun, 28 Jul 2019, Masahiro Yamada wrote:
> 
> Since CONFIG_PREEMPTION was introduced after -rc1,
> I think this should be queued on top of -rc2.

Right. Are you picking it up?

> > -#ifdef CONFIG_PREEMPT
> > -#define MODULE_VERMAGIC_PREEMPT "preempt "
> > +#ifdef CONFIG_PREEMPTION
> > +# ifdef CONFIG_PREEMPT
> > +#  define MODULE_VERMAGIC_PREEMPT "preempt "
> > +# else
> > +#  define MODULE_VERMAGIC_PREEMPT "preempt_rt "
> > +# endif
> >  #else
> > -#define MODULE_VERMAGIC_PREEMPT ""
> > +# define MODULE_VERMAGIC_PREEMPT ""
> 
> Maybe, is the following more readable?
> 
> #if defined(CONFIG_PREEMPT_RT)
> #define MODULE_VERMAGIC_PREEMPT "preempt_rt "
> #elif defined(CONFIG_PREEMPT)
> #define MODULE_VERMAGIC_PREEMPT "preempt "
> #else
> #define MODULE_VERMAGIC_PREEMPT ""
> #endif

Doh. That's obvious. Must be a result of the heat wave we had.
Will send a V2.

Thanks,

	tglx