linux-kernel - Re: [PATCH] [RFC] dmaengine: add fifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729061010.GC12733@vkoul-mobl.Dlink>
Date:   Mon, 29 Jul 2019 11:40:10 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Sameer Pujar <spujar@...dia.com>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>, dan.j.williams@...el.com,
        tiwai@...e.com, jonathanh@...dia.com, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, sharadg@...dia.com,
        rlokhande@...dia.com, dramesh@...dia.com, mkumard@...dia.com
Subject: Re: [PATCH] [RFC] dmaengine: add fifo_size member

On 23-07-19, 11:24, Sameer Pujar wrote:
> 
> On 7/19/2019 10:34 AM, Vinod Koul wrote:
> > On 05-07-19, 11:45, Sameer Pujar wrote:
> > > Hi Vinod,
> > > 
> > > What are your final thoughts regarding this?
> > Hi sameer,
> > 
> > Sorry for the delay in replying
> > 
> > On this, I am inclined to think that dma driver should not be involved.
> > The ADMAIF needs this configuration and we should take the path of
> > dma_router for this piece and add features like this to it
> 
> Hi Vinod,
> 
> The configuration is needed by both ADMA and ADMAIF. The size is
> configurable
> on ADMAIF side. ADMA needs to know this info and program accordingly.

Well I would say client decides the settings for both DMA, DMAIF and
sets the peripheral accordingly as well, so client communicates the two
sets of info to two set of drivers

> Not sure if dma_router can help to achieve this.
> 
> I checked on dma_router. It would have been useful when a configuration
> exported
> via ADMA, had to be applied to ADMAIF. Please correct me if I am wrong here.

router was added for such a senario, if you feel that it doesn't serve
your purpose, feel free to send up update for it, if that is the case.

Thanks

-- 
~Vinod