linux-kernel - Re: [PATCH 1/1] psi: do not require setsched permission from the trigger creator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729195614.GA31529@kroah.com>
Date:   Mon, 29 Jul 2019 21:56:14 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Suren Baghdasaryan <surenb@...gle.com>
Cc:     lizefan@...wei.com, hannes@...xchg.org, axboe@...nel.dk,
        dennis@...nel.org, dennisszhou@...il.com, mingo@...hat.com,
        peterz@...radead.org, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        Nick Kralevich <nnk@...gle.com>
Subject: Re: [PATCH 1/1] psi: do not require setsched permission from the
 trigger creator

On Mon, Jul 29, 2019 at 12:42:05PM -0700, Suren Baghdasaryan wrote:
> When a process creates a new trigger by writing into /proc/pressure/*
> files, permissions to write such a file should be used to determine whether
> the process is allowed to do so or not. Current implementation would also
> require such a process to have setsched capability. Setting of psi trigger
> thread's scheduling policy is an implementation detail and should not be
> exposed to the user level. Remove the permission check by using _nocheck
> version of the function.
> 
> Suggested-by: Nick Kralevich <nnk@...gle.com>
> Signed-off-by: Suren Baghdasaryan <surenb@...gle.com>
> ---
>  kernel/sched/psi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

$ ./scripts/get_maintainer.pl --file kernel/sched/psi.c
Ingo Molnar <mingo@...hat.com> (maintainer:SCHEDULER)
Peter Zijlstra <peterz@...radead.org> (maintainer:SCHEDULER)
linux-kernel@...r.kernel.org (open list:SCHEDULER)


No where am I listed there, so why did you send this "To:" me?

please fix up and resend.

greg k-h