linux-kernel - Re: [RFC 3/9] workqueue: require CPU hotplug read exclusion for apply_workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729194721.GG569612@devbig004.ftw2.facebook.com>
Date:   Mon, 29 Jul 2019 12:47:21 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Daniel Jordan <daniel.m.jordan@...cle.com>
Cc:     Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 3/9] workqueue: require CPU hotplug read exclusion for
 apply_workqueue_attrs

On Thu, Jul 25, 2019 at 05:24:59PM -0400, Daniel Jordan wrote:
> Change the calling convention for apply_workqueue_attrs to require CPU
> hotplug read exclusion.
> 
> Avoids lockdep complaints about nested calls to get_online_cpus in a
> future patch where padata calls apply_workqueue_attrs when changing
> other CPU-hotplug-sensitive data structures with the CPU read lock
> already held.
> 
> Signed-off-by: Daniel Jordan <daniel.m.jordan@...cle.com>

Acked-by: Tejun Heo <tj@...nel.org>

Please feel free to route with the rest of the patchset.

Thanks.

-- 
tejun