linux-kernel - Re: [PATCH] net: wan: sdla: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190729.140905.1605231050316978110.davem@davemloft.net>
Date:   Mon, 29 Jul 2019 14:09:05 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     gustavo@...eddedor.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        keescook@...omium.org
Subject: Re: [PATCH] net: wan: sdla: Mark expected switch fall-through

From: "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Date: Mon, 29 Jul 2019 15:01:39 -0500

> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: i386):
> 
> drivers/net/wan/sdla.c: In function ‘sdla_errors’:
> drivers/net/wan/sdla.c:414:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     if (cmd == SDLA_INFORMATION_WRITE)
>        ^
> drivers/net/wan/sdla.c:417:3: note: here
>    default:
>    ^~~~~~~
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Applied.