linux-kernel - Re: linux-next: build warning after merge of Linus' tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h8sshpbt3.wl-tiwai@suse.de>
Date:   Mon, 29 Jul 2019 08:58:00 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Johannes Berg <johannes@...solutions.net>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of Linus' tree

On Mon, 29 Jul 2019 06:04:04 +0200,
Stephen Rothwell wrote:
> 
> Hi all,
> 
> After merging the origin tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get':
> sound/aoa/codecs/onyx.c:377:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity;
>                                      ^~~~~~~~~~~~
> 
> Introduced by commit
> 
>   f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa")
> 
> This warning has been around for a long time.  It could possibly be
> suppressed by checking for errors returned by onyx_read_register().

Yes, or simply zero-ing the variable in onyx_read_register().  The
current code ignores the read error and it's been OK over a decade :)


thanks,

Takashi