linux-kernel - Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum of task_h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <97675ac29db1339ff683bf7eacf97540b00bd2a1.camel@surriel.com>
Date:   Mon, 29 Jul 2019 17:13:50 -0400
From:   Rik van Riel <riel@...riel.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...com, pjt@...gle.com,
        dietmar.eggemann@....com, mingo@...hat.com,
        morten.rasmussen@....com, tglx@...utronix.de,
        mgorman@...hsingularity.net, vincent.guittot@...aro.org
Subject: Re: [PATCH 03/14] sched,fair: redefine runnable_load_avg as the sum
 of task_h_load

On Mon, 2019-07-29 at 22:05 +0200, Peter Zijlstra wrote:
> On Mon, Jul 22, 2019 at 01:33:37PM -0400, Rik van Riel wrote:
> > @@ -3012,25 +2983,24 @@ static inline int
> > throttled_hierarchy(struct cfs_rq *cfs_rq);
> >  static void update_cfs_group(struct sched_entity *se)
> >  {
> >  	struct cfs_rq *gcfs_rq = group_cfs_rq(se);
> > -	long shares, runnable;
> > +	long shares;
> >  
> > -	if (!gcfs_rq)
> > +	if (!gcfs_rq) {
> > +		update_runnable_load_avg(se);
> >  		return;
> > +	}
> >  
> >  	if (throttled_hierarchy(gcfs_rq))
> >  		return;
> >  
> >  #ifndef CONFIG_SMP
> > -	runnable = shares = READ_ONCE(gcfs_rq->tg->shares);
> > -
> >  	if (likely(se->load.weight == shares))
> 
> I'm thinking this uses @shares uninitialized...

Oops indeed. Let me put the shares = assignment
back for the !SMP case, and edit that comment.

> >  		return;
> >  #else
> >  	shares   = calc_group_shares(gcfs_rq);
> > -	runnable = calc_group_runnable(gcfs_rq, shares);
> >  #endif
> >  
> > -	reweight_entity(cfs_rq_of(se), se, shares, runnable);
> > +	reweight_entity(cfs_rq_of(se), se, shares);
> >  }
-- 
All Rights Reversed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)