linux-kernel - Re: [PATCH] ataflop: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80ad9bf9-4d50-a436-586c-dd9775e3e186@kernel.dk>
Date:   Mon, 29 Jul 2019 15:25:17 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] ataflop: Mark expected switch fall-through

On 7/29/19 3:10 PM, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: m68k):
> 
> drivers/block/ataflop.c: In function ‘fd_locked_ioctl’:
> drivers/block/ataflop.c:1728:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     set_capacity(floppy->disk, MAX_DISK_SIZE * 2);
>     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/block/ataflop.c:1729:2: note: here
>    case FDFMTEND:
>    ^~~~

Applied, thanks.

-- 
Jens Axboe