[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <32f08aa4-c9a3-9545-69aa-2cc3695e15df@nvidia.com>
Date: Mon, 29 Jul 2019 16:29:55 -0700
From: Ralph Campbell <rcampbell@...dia.com>
To: Christoph Hellwig <hch@....de>,
Jérôme Glisse <jglisse@...hat.com>,
Jason Gunthorpe <jgg@...lanox.com>,
Ben Skeggs <bskeggs@...hat.com>
CC: Bharata B Rao <bharata@...ux.ibm.com>,
Andrew Morton <akpm@...ux-foundation.org>,
<linux-mm@...ck.org>, <nouveau@...ts.freedesktop.org>,
<dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/9] mm: remove the unused MIGRATE_PFN_ERROR flag
On 7/29/19 7:28 AM, Christoph Hellwig wrote:
> We don't use this flag anymore, so remove it.
>
> Signed-off-by: Christoph Hellwig <hch@....de>
Reviewed-by: Ralph Campbell <rcampbell@...dia.com>
> ---
> include/linux/migrate.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/migrate.h b/include/linux/migrate.h
> index 093d67fcf6dd..229153c2c496 100644
> --- a/include/linux/migrate.h
> +++ b/include/linux/migrate.h
> @@ -167,7 +167,6 @@ static inline int migrate_misplaced_transhuge_page(struct mm_struct *mm,
> #define MIGRATE_PFN_LOCKED (1UL << 2)
> #define MIGRATE_PFN_WRITE (1UL << 3)
> #define MIGRATE_PFN_DEVICE (1UL << 4)
> -#define MIGRATE_PFN_ERROR (1UL << 5)
> #define MIGRATE_PFN_SHIFT 6
The MIGRATE_PFN_SHIFT could be reduced to 5 since it is only used
to make room for the flags.
> static inline struct page *migrate_pfn_to_page(unsigned long mpfn)
>
Powered by blists - more mailing lists