linux-kernel - [PATCH] mm/gup: remove unused variable in siw_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190729074306.10368-1-jhubbard@nvidia.com>
Date:   Mon, 29 Jul 2019 00:43:06 -0700
From:   john.hubbard@...il.com
To:     sfr@...b.auug.org.au
Cc:     akpm@...ux-foundation.org, jhubbard@...dia.com,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org
Subject: [PATCH] mm/gup: remove unused variable in siw_free_plist()

From: John Hubbard <jhubbard@...dia.com>

Commit 63630f9a8d72 ("mm/gup: add make_dirty arg to
put_user_pages_dirty_lock()") removed the only user of the
local variable p. Finish the job by removing p as well.

Fixes: 63630f9a8d72 ("mm/gup: add make_dirty arg to put_user_pages_dirty_lock()")
Signed-off-by: John Hubbard <jhubbard@...dia.com>
---

Hi,

This fixes the warning. Ideally this should be merged with the commit
that it fixes, if that's still possible.

Andrew, would you also like a fixed version of this patch posted
as a new version of the 3-patch set that it came with?

thanks,
John Hubbard
NVIDIA

 drivers/infiniband/sw/siw/siw_mem.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/infiniband/sw/siw/siw_mem.c b/drivers/infiniband/sw/siw/siw_mem.c
index 358d440efa11..ab83a9cec562 100644
--- a/drivers/infiniband/sw/siw/siw_mem.c
+++ b/drivers/infiniband/sw/siw/siw_mem.c
@@ -63,8 +63,6 @@ struct siw_mem *siw_mem_id2obj(struct siw_device *sdev, int stag_index)
 static void siw_free_plist(struct siw_page_chunk *chunk, int num_pages,
 			   bool dirty)
 {
-	struct page **p = chunk->plist;
-
 	put_user_pages_dirty_lock(chunk->plist, num_pages, dirty);
 }
 
-- 
2.22.0