[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAEnQRZDwAQZ7E=ayJeZCvXJ8fyayCmpAqe9=oLm4gxw8zoN0oQ@mail.gmail.com>
Date: Mon, 29 Jul 2019 12:03:45 +0300
From: Daniel Baluta <daniel.baluta@...il.com>
To: Guido Günther <agx@...xcpu.org>
Cc: Daniel Baluta <daniel.baluta@....com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
dl-linux-imx <linux-imx@....com>,
Lucas Stach <l.stach@...gutronix.de>,
Carlo Caione <ccaione@...libre.com>,
Abel Vesa <abel.vesa@....com>, baruch@...s.co.il,
Andrey Smirnov <andrew.smirnov@...il.com>,
Devicetree List <devicetree@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"S.j. Wang" <shengjiu.wang@....com>,
"Angus Ainslie (Purism)" <angus@...ea.ca>,
Anson Huang <Anson.Huang@....com>
Subject: Re: [PATCH v3] arm64: dts: imx8mq: Init rates and parents configs for clocks
On Mon, Jul 29, 2019 at 11:32 AM Guido Günther <agx@...xcpu.org> wrote:
>
> Hi,
> On Sun, Jul 28, 2019 at 05:12:18PM +0300, Daniel Baluta wrote:
> > From: Abel Vesa <abel.vesa@....com>
> >
> > Add the initial configuration for clocks that need default parent and rate
> > setting. This is based on the vendor tree clock provider parents and rates
> > configuration except this is doing the setup in dts rather then using clock
> > consumer API in a clock provider driver.
> >
> > Note that by adding the initial rate setting for audio_pll1/audio_pll
> > setting we need to remove it from imx8mq-librem5-devkit.dts
> > imx8mq-librem5-devkit.dts
> >
> > Signed-off-by: Abel Vesa <abel.vesa@....com>
> > Signed-off-by: Daniel Baluta <daniel.baluta@....com>
> > ---
> > Changes since v2:
> > - set rate for audio_pll1/audio_pll2 in the dtsi file and
> > remove the setting from imx8mq-librem5-devkit.dts
> >
> > .../dts/freescale/imx8mq-librem5-devkit.dts | 5 -----
> > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 21 +++++++++++++++++++
> > 2 files changed, 21 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > index 683a11035643..c702ccc82867 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts
> > @@ -169,11 +169,6 @@
> > };
> > };
> >
> > -&clk {
> > - assigned-clocks = <&clk IMX8MQ_AUDIO_PLL1>, <&clk IMX8MQ_AUDIO_PLL2>;
> > - assigned-clock-rates = <786432000>, <722534400>;
> > -};
> > -
> > &dphy {
> > status = "okay";
> > };
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > index 02fbd0625318..c67625a881a4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > @@ -494,6 +494,27 @@
> > clock-names = "ckil", "osc_25m", "osc_27m",
> > "clk_ext1", "clk_ext2",
> > "clk_ext3", "clk_ext4";
> > + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL1>,
> > + <&clk IMX8MQ_AUDIO_PLL2>,
> > + <&clk IMX8MQ_CLK_AHB>,
> > + <&clk IMX8MQ_CLK_NAND_USDHC_BUS>,
> > + <&clk IMX8MQ_CLK_AUDIO_AHB>,
> > + <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>,
> > + <&clk IMX8MQ_CLK_NOC>;
> > + assigned-clock-parents = <0>,
> > + <0>,
> > + <0>,
> > + <&clk IMX8MQ_SYS1_PLL_133M>,
> > + <&clk IMX8MQ_SYS1_PLL_266M>,
> > + <&clk IMX8MQ_SYS2_PLL_500M>,
> > + <&clk IMX8MQ_CLK_27M>,
> > + <&clk IMX8MQ_SYS1_PLL_800M>;
> > + assigned-clock-rates = <593999999>,
> > + <786432000>,
> > + <722534400>;
> > +
> > +
> > };
> >
> > src: reset-controller@...90000 {
>
> togethe with http://code.bulix.org/pd88jp-812381?raw tested on
> linux-20190725 (plus mipi dsi):
>
> Tested-by: Guido Günther <agx@...xcpu.org>
Thanks for testing this Guido. Can you please add your Tested-by
to my fourth version of the patch.
[PATCH v4] arm64: dts: imx8mq: Init rates and parents configs for clocks
Powered by blists - more mailing lists