lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 29 Jul 2019 10:49:00 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Anders Roxell <anders.roxell@...aro.org>
Cc:     Catalin Marinas <catalin.marinas@....com>, will@...nel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        kvmarm@...ts.cs.columbia.edu,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] arm64: KVM: hyp: debug-sr: Mark expected switch fall-through

On Fri, 26 Jul 2019 15:11:05 +0100,
Anders Roxell <anders.roxell@...aro.org> wrote:
> 
> On Fri, 26 Jul 2019 at 14:31, Marc Zyngier <marc.zyngier@....com> wrote:
> >
> > On Fri, 26 Jul 2019 12:27:10 +0100,
> > Anders Roxell <anders.roxell@...aro.org> wrote:
> > >
> > > When fall-through warnings was enabled by default the following warnings
> > > was starting to show up:
> > >
> > > ../arch/arm64/kvm/hyp/debug-sr.c: In function ‘__debug_save_state’:
> > > ../arch/arm64/kvm/hyp/debug-sr.c:20:19: warning: this statement may fall
> > >  through [-Wimplicit-fallthrough=]
> > >   case 15: ptr[15] = read_debug(reg, 15);   \
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > >   save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > >   ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:21:2: note: here
> > >   case 14: ptr[14] = read_debug(reg, 14);   \
> > >   ^~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > >   save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > >   ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:21:19: warning: this statement may fall
> > >  through [-Wimplicit-fallthrough=]
> > >   case 14: ptr[14] = read_debug(reg, 14);   \
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > >   save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > >   ^~~~~~~~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:22:2: note: here
> > >   case 13: ptr[13] = read_debug(reg, 13);   \
> > >   ^~~~
> > > ../arch/arm64/kvm/hyp/debug-sr.c:113:2: note: in expansion of macro ‘save_debug’
> > >   save_debug(dbg->dbg_bcr, dbgbcr, brps);
> > >   ^~~~~~~~~~
> > >
> > > Rework to add a 'break;' where the compiler warned about
> > > fall-through.
> >
> > That's not what this patch does, I'm afraid.
> 
> urgh I'm sorry.
> Sending a v2 shortly.

Don't bother, I'll fix it locally.

Thanks,

	M.

-- 
Jazz is not dead, it just smells funny.

Powered by blists - more mailing lists