linux-kernel - Re: [PATCH] arm64: mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190729100043.keo3kfsbgbbcthml@willie-the-truck>
Date:   Mon, 29 Jul 2019 11:00:43 +0100
From:   Will Deacon <will@...nel.org>
To:     Matteo Croce <mcroce@...hat.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Marc Zyngier <maz@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: mark expected switch fall-through

On Mon, Jul 29, 2019 at 01:03:10AM +0200, Matteo Croce wrote:
> Move the "fallthrough" comment just because the case keyword,
> fixes the following warning:
> 
> In file included from ./include/linux/kernel.h:15,
>                  from ./include/linux/list.h:9,
>                  from ./include/linux/kobject.h:19,
>                  from ./include/linux/of.h:17,
>                  from ./include/linux/irqdomain.h:35,
>                  from ./include/linux/acpi.h:13,
>                  from arch/arm64/kernel/smp.c:9:
> arch/arm64/kernel/smp.c: In function ‘__cpu_up’:
> ./include/linux/printk.h:302:2: warning: this statement may fall through [-Wimplicit-fallthrough=]
>   printk(KERN_CRIT pr_fmt(fmt), ##__VA_ARGS__)
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> arch/arm64/kernel/smp.c:156:4: note: in expansion of macro ‘pr_crit’
>     pr_crit("CPU%u: may not have shut down cleanly\n", cpu);
>     ^~~~~~~
> arch/arm64/kernel/smp.c:157:3: note: here
>    case CPU_STUCK_IN_KERNEL:
>    ^~~~
> 
> Signed-off-by: Matteo Croce <mcroce@...hat.com>
> ---
>  arch/arm64/kernel/smp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Already fixed via [1]. Please can you people work together?

Will

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-July/668934.html