linux-kernel - Re: [PATCH] drm: mali-dp: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dce9bae1-bfd9-1945-f90c-735ef9b0bd07@embeddedor.com>
Date:   Mon, 29 Jul 2019 05:28:08 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Liviu Dudau <Liviu.Dudau@....com>,
        Anders Roxell <anders.roxell@...aro.org>
Cc:     airlied@...ux.ie, daniel@...ll.ch, stable@...r.kernel.org,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: mali-dp: Mark expected switch fall-through



On 7/29/19 4:58 AM, Liviu Dudau wrote:

>>  		case MW_RESTART:
>>  			drm_writeback_signal_completion(&malidp->mw_connector, 0);
>> -			/* fall through to a new start */
> 
> It's a shame that the compiler throws a warning here, it would've been really
> useful to keep the hint that going back to a new start is intentional without
> having to type another comment.
> 

You don't have to remove the rest of the comment. For a one-line comment this works
just fine:

/* fall through - to a new start */

--
Gustavo