[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ec98fd7e-5a2b-6f0e-8a23-3fde2161d4e7@collabora.com>
Date: Mon, 29 Jul 2019 13:29:15 +0200
From: Enric Balletbo i Serra <enric.balletbo@...labora.com>
To: Hyungwoo Yang <hyungwoo.yang@...el.com>
Cc: linux-kernel@...r.kernel.org, rushikesh.s.kadam@...el.com,
jettrink@...omium.org, Benson Leung <bleung@...omium.org>,
Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH] platform/chrome: fix crash during suspend
Hi,
cc'ing: Benson and Guenter
Please don't forget to add all the chrome-platform maintainers in the cc list.
On 30/5/19 6:03, Hyungwoo Yang wrote:
> Kernel crashes during suspend due to wrong conversion in
> suspend and resume functions.
>
> Use the proper helper to get ishtp_cl_device instance.
>
> Signed-off-by: Hyungwoo Yang <hyungwoo.yang@...el.com>
I added the cros_ec_ishtp prefix in the subject and cc'ied stable to apply this
for 5.2+ (the patch depends on "b12bbdc5: HID: intel-ish-hid: fix wrong
driver_data usage")
The patch will be pushed to the chrome-platform-5.3-fixes branch for the
autobuilders to play with, if all goes well we will do a fixes PR during this cycle.
Thanks,
~ Enric
> ---
> drivers/platform/chrome/cros_ec_ishtp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
> index e504d25..430731c 100644
> --- a/drivers/platform/chrome/cros_ec_ishtp.c
> +++ b/drivers/platform/chrome/cros_ec_ishtp.c
> @@ -707,7 +707,7 @@ static int cros_ec_ishtp_reset(struct ishtp_cl_device *cl_device)
> */
> static int __maybe_unused cros_ec_ishtp_suspend(struct device *device)
> {
> - struct ishtp_cl_device *cl_device = dev_get_drvdata(device);
> + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device);
> struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device);
> struct ishtp_cl_data *client_data = ishtp_get_client_data(cros_ish_cl);
>
> @@ -722,7 +722,7 @@ static int __maybe_unused cros_ec_ishtp_suspend(struct device *device)
> */
> static int __maybe_unused cros_ec_ishtp_resume(struct device *device)
> {
> - struct ishtp_cl_device *cl_device = dev_get_drvdata(device);
> + struct ishtp_cl_device *cl_device = ishtp_dev_to_cl_device(device);
> struct ishtp_cl *cros_ish_cl = ishtp_get_drvdata(cl_device);
> struct ishtp_cl_data *client_data = ishtp_get_client_data(cros_ish_cl);
>
>
Powered by blists - more mailing lists