linux-kernel - Re: [PATCH v2] clk: imx8mq: Mark AHB clock as critical

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 09:19:01 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Abel Vesa <abel.vesa@....com>
Cc:     Mike Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Guido Gunther <agx@...xcpu.org>,
        Anson Huang <anson.huang@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clk: imx8mq: Mark AHB clock as critical

Hi Abel,

On Mon, Jul 29, 2019 at 4:23 AM Abel Vesa <abel.vesa@....com> wrote:
>
> Keep the AHB clock always on since there is no driver to control it and
> all the other clocks that use it as parent rely on it being always enabled.
>
> Signed-off-by: Abel Vesa <abel.vesa@....com>
> Tested-by: Daniel Baluta <daniel.baluta@....com>
> ---
>
> Changes since v1:
>  * added comment in code why this clock is critical
>  * added T-b by Daniel
>
> This needs to go in ASAP to fix the boot hang.

Which boot hang exactly? Are you referring to the TMU clock hang?

On the TMU clock hang, the issue was that the qoriq_thermal needs to
enable the TMU clock.

Please always provide a detailed description in the commit log.

Also, if this fixes a hang it should contain a Fixes tag.