linux-kernel - Re: [PATCH v2] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bacac922-a15d-77c4-e549-cbf41100e4ef@collabora.com>
Date:   Mon, 29 Jul 2019 14:51:59 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Tzung-Bi Shih <tzungbi@...gle.com>, bleung@...omium.org,
        groeck@...omium.org
Cc:     linux-kernel@...r.kernel.org, cychiang@...gle.com,
        dgreid@...gle.com
Subject: Re: [PATCH v2] platform/chrome: cros_ec_trace: update generating
 script

Hi Tzung-Bi

On 23/7/19 15:33, Tzung-Bi Shih wrote:
> To remove ", \" from the last line.
> 
> Signed-off-by: Tzung-Bi Shih <tzungbi@...gle.com>
> ---
> Changes from v1:
> - simpler awk code
> 
>  drivers/platform/chrome/cros_ec_trace.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_trace.c b/drivers/platform/chrome/cros_ec_trace.c
> index 0a76412095a9..667460952dad 100644
> --- a/drivers/platform/chrome/cros_ec_trace.c
> +++ b/drivers/platform/chrome/cros_ec_trace.c
> @@ -6,7 +6,18 @@
>  #define TRACE_SYMBOL(a) {a, #a}
>  
>  // Generate the list using the following script:
> -// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' include/linux/mfd/cros_ec_commands.h
> +// sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' \

For some reason I accepted the patch using c++ style comments but I shouldn't,
while we are here could you update the patch and use c style comments instead,
thanks.

~ Enric

> +// include/linux/mfd/cros_ec_commands.h | awk '
> +// {
> +//   if (NR != 1)
> +//     print buf;
> +//   buf = $0;
> +// }
> +// END {
> +//   gsub(/, \\/, "", buf);
> +//   print buf;
> +// }
> +// '
>  #define EC_CMDS \
>  	TRACE_SYMBOL(EC_CMD_PROTO_VERSION), \
>  	TRACE_SYMBOL(EC_CMD_HELLO), \
>