[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190729132203.GB1201@penguin>
Date: Mon, 29 Jul 2019 15:22:03 +0200
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Ronald Tschalär <ronald@...ovation.ch>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Mao Wenan <maowenan@...wei.com>,
Federico Lorenzi <federico@...velground.com>,
linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Input: applespi - register touchpad device
synchronously in probe
Hi Ronald,
On Sun, Jul 21, 2019 at 12:05:23AM -0700, Ronald Tschalär wrote:
> This allows errors during registration to properly fail the probe
> function.
>
> Doing this requires waiting for a response from the device inside the
> probe function. While this generally takes about 15ms, in case of errors
> it could be arbitrarily long, and hence a 3 second timeout is used.
>
> This also adds 3 second timeouts to the drain functions to avoid the
> potential for suspend or remove hanging forever.
Question: is it possible to read command response synchronously as well?
I.e. I was wondering if we could add 2 (or 1?) more read xfers for the
actual result that is coming after the status response, and then we
could use spi_sync() to send the command and read the whole thing.
Thanks.
--
Dmitry
Powered by blists - more mailing lists