linux-kernel - [PATCH] scsi: mpt3sas: Fix a possible null-pointer dereference in mpt3sas_transport_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 11:08:51 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     sathya.prakash@...adcom.com, chaitra.basappa@...adcom.com,
        suganath-prabu.subramani@...adcom.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jia-Ju Bai <baijiaju1990@...il.com>
Subject: [PATCH] scsi: mpt3sas: Fix a possible null-pointer dereference in mpt3sas_transport_update_links()

In mpt3sas_transport_update_links(), there is an if statement 
on line 994 to check whether mpt3sas_phy->phy is NULL:
    if (mpt3sas_phy->phy)

When mpt3sas_phy->phy is NULL, it is used on line 999:
    dev_printk(KERN_INFO, &mpt3sas_phy->phy->dev, ...)

Thus, a possible null-pointer dereference may occur.

To fix this bug, mpt3sas_phy->phy is checked before being used.

This bug is found by a static analysis tool STCheck written by us.

Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>
---
 drivers/scsi/mpt3sas/mpt3sas_transport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_transport.c b/drivers/scsi/mpt3sas/mpt3sas_transport.c
index 5324662751bf..df790a9877a0 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_transport.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_transport.c
@@ -995,7 +995,8 @@ mpt3sas_transport_update_links(struct MPT3SAS_ADAPTER *ioc,
 		mpt3sas_phy->phy->negotiated_linkrate =
 		    _transport_convert_phy_link_rate(link_rate);
 
-	if ((ioc->logging_level & MPT_DEBUG_TRANSPORT))
+	if ((ioc->logging_level & MPT_DEBUG_TRANSPORT) && 
+			mpt3sas_phy->phy)
 		dev_printk(KERN_INFO, &mpt3sas_phy->phy->dev,
 		    "refresh: parent sas_addr(0x%016llx),\n"
 		    "\tlink_rate(0x%02x), phy(%d)\n"
-- 
2.17.0