linux-kernel - Re: [PATCH] Makefile: Globally enable fall-through warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 09:42:53 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] Makefile: Globally enable fall-through warning

Hi Geert,

On 7/29/19 3:22 AM, Geert Uytterhoeven wrote:

> 
> More to be found in
> https://lore.kernel.org/lkml/20190729081727.6094-1-geert@linux-m68k.org/
> 

I already sent out patches for many of those. :)

Thanks a lot!

> and I saw the following in my local builds (not detected above due to
> kisskb using an older compiler for m68k builds):
> 
> arch/m68k/include/asm/amigahw.h: warning: this statement may fall
> through [-Wimplicit-fallthrough=]:  => 42:50
> drivers/block/ataflop.c: warning: this statement may fall through
> [-Wimplicit-fallthrough=]:  => 1728:3
> drivers/net/arcnet/com20020-isa.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]:  => 205:13, 203:10, 209:7, 201:11,
> 207:8
> drivers/scsi/sun3_scsi.c: warning: this statement may fall through
> [-Wimplicit-fallthrough=]:  => 399:9, 403:9
> sound/oss/dmasound/dmasound_atari.c: warning: this statement may fall
> through [-Wimplicit-fallthrough=]:  => 1449:24
> 

I already sent patches for some of the ones above, too. Although, I have
some doubts with the one at arch/m68k/amiga/config.c:223

We can talk about it in a separate thread.

> Thanks for fixing ;-)
> 

Glad to help. :)

Thanks
--
Gustavo