linux-kernel - Re: [PATCH] exit: make setting exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729163025.4jc6d4nkdcdhve2k@brauner.io>
Date:   Mon, 29 Jul 2019 18:30:27 +0200
From:   Christian Brauner <christian@...uner.io>
To:     oleg@...hat.com, linux-kernel@...r.kernel.org
Cc:     akpm@...ux-foundation.org, tj@...nel.org, tglx@...utronix.de,
        prsood@...eaurora.org, avagin@...il.com,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] exit: make setting exit_state consistent

On Mon, Jul 29, 2019 at 06:27:57PM +0200, Christian Brauner wrote:
> Since commit [1] we unconditionally set exit_state to EXIT_ZOMBIE before
> calling into do_notify_parent(). This was done to eliminate a race when
> querying exit_state in do_notify_pidfd().
> Back then we decided to do the absolute minimal thing to fix this and
> not touch the rest of the exit_notify() function where exit_state is
> set.
> Since this fix has not caused any issues change the setting of
> exit_state to EXIT_DEAD in the autoreap case to account for the fact hat
> exit_state is set to EXIT_ZOMBIE unconditionally. This fix was planned
> but also explicitly requested in [2] and makes the whole code more
> consistent.
> 
> /* References */
> [1]: b191d6491be6 ("pidfd: fix a poll race when setting exit_state")
> [2]: https://lore.kernel.org/lkml/CAHk-=wigcxGFR2szue4wavJtH5cYTTeNES=toUBVGsmX0rzX+g@mail.gmail.com
> 
> Signed-off-by: Christian Brauner <christian@...uner.io>
> Cc: Oleg Nesterov <oleg@...hat.com>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>

I plan on sending this together with a few other fixes later. (Assuming
the change here is correct of course.)

Christian