lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Jul 2019 09:35:24 -0700 From: Kees Cook <keescook@...omium.org> To: "Gustavo A. R. Silva" <gustavo@...eddedor.com> Cc: Tony Lindgren <tony@...mide.com>, Lee Jones <lee.jones@...aro.org>, linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au> Subject: Re: [PATCH] mfd: omap-usb-host: Mark expected switch fall-throughs On Sun, Jul 28, 2019 at 06:58:58PM -0500, Gustavo A. R. Silva wrote: > Mark switch cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_resume': > drivers/mfd/omap-usb-host.c:303:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (!IS_ERR(omap->hsic480m_clk[i])) { > ^ > drivers/mfd/omap-usb-host.c:313:3: note: here > case OMAP_EHCI_PORT_MODE_TLL: > ^~~~ > drivers/mfd/omap-usb-host.c: In function 'usbhs_runtime_suspend': > drivers/mfd/omap-usb-host.c:345:7: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (!IS_ERR(omap->hsic480m_clk[i])) > ^ > drivers/mfd/omap-usb-host.c:349:3: note: here > case OMAP_EHCI_PORT_MODE_TLL: > ^~~~ > > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au> > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> Reviewed-by: Kees Cook <keescook@...omium.org> -Kees > --- > drivers/mfd/omap-usb-host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > index 792b855a9104..4798d9f3f9d5 100644 > --- a/drivers/mfd/omap-usb-host.c > +++ b/drivers/mfd/omap-usb-host.c > @@ -308,7 +308,7 @@ static int usbhs_runtime_resume(struct device *dev) > i, r); > } > } > - /* Fall through as HSIC mode needs utmi_clk */ > + /* Fall through - as HSIC mode needs utmi_clk */ > > case OMAP_EHCI_PORT_MODE_TLL: > if (!IS_ERR(omap->utmi_clk[i])) { > @@ -344,7 +344,7 @@ static int usbhs_runtime_suspend(struct device *dev) > > if (!IS_ERR(omap->hsic480m_clk[i])) > clk_disable_unprepare(omap->hsic480m_clk[i]); > - /* Fall through as utmi_clks were used in HSIC mode */ > + /* Fall through - as utmi_clks were used in HSIC mode */ > > case OMAP_EHCI_PORT_MODE_TLL: > if (!IS_ERR(omap->utmi_clk[i])) > -- > 2.22.0 > -- Kees Cook
Powered by blists - more mailing lists