[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20190729164226.22632-1-navid.emamdoost@gmail.com>
Date: Mon, 29 Jul 2019 11:42:26 -0500
From: Navid Emamdoost <navid.emamdoost@...il.com>
To: josef@...icpanda.com
Cc: kjlu@....edu, smccaman@....edu, secalert@...hat.com,
emamd001@....edu, Navid Emamdoost <navid.emamdoost@...il.com>,
Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
nbd@...er.debian.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] nbd_genl_status: null check for nla_nest_start
nla_nest_start may fail and return NULL. The check is inserted, and
errno is selected based on other call sites within the same source code.
Update: removed extra new line.
Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>
---
drivers/block/nbd.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 9bcde2325893..2410812d1e82 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -2149,6 +2149,11 @@ static int nbd_genl_status(struct sk_buff *skb, struct genl_info *info)
}
dev_list = nla_nest_start_noflag(reply, NBD_ATTR_DEVICE_LIST);
+ if (!dev_list) {
+ ret = -EMSGSIZE;
+ goto out;
+ }
+
if (index == -1) {
ret = idr_for_each(&nbd_index_idr, &status_cb, reply);
if (ret) {
--
2.17.1
Powered by blists - more mailing lists