linux-kernel - Re: [PATCH v3 2/2] pidfd: add pidfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190729175523.5mca4wnmoldu2olp@brauner.io>
Date:   Mon, 29 Jul 2019 19:55:23 +0200
From:   Christian Brauner <christian@...uner.io>
To:     Kees Cook <keescook@...omium.org>
Cc:     linux-kernel@...r.kernel.org, oleg@...hat.com,
        torvalds@...ux-foundation.org, arnd@...db.de,
        ebiederm@...ssion.com, joel@...lfernandes.org, tglx@...utronix.de,
        tj@...nel.org, dhowells@...hat.com, jannh@...gle.com,
        luto@...nel.org, akpm@...ux-foundation.org, cyphar@...har.com,
        viro@...iv.linux.org.uk, kernel-team@...roid.com
Subject: Re: [PATCH v3 2/2] pidfd: add pidfd_wait tests

On Mon, Jul 29, 2019 at 09:31:23AM -0700, Kees Cook wrote:
> On Sun, Jul 28, 2019 at 12:22:30AM +0200, Christian Brauner wrote:
> > Add tests for pidfd_wait() and CLONE_WAIT_PID:
> > - test that waitid(P_PIDFD) can wait on a pidfd
> > - test that waitid(P_PIDFD) can wait on a pidfd and return siginfo_t
> > - test that waitid(P_PIDFD) works with WEXITED
> > - test that waitid(P_PIDFD) works with WSTOPPED
> > - test that waitid(P_PIDFD) works with WUNTRACED
> > - test that waitid(P_PIDFD) works with WCONTINUED
> > - test that waitid(P_PIDFD) works with WNOWAIT
> > - test that waitid(P_PIDFD)works with WNOHANG
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> This all looks good to me! :) One note that doesn't apply to this patch
> in particular, but might be nice to add (as I didn't see in the existing
> tests) was testing for pathological conditions: passing in /dev/zero for
> the pidfd, etc. (Maybe I missed those?)

Yeah, I can probably just add one for this scenario. :)

Thanks!
Christian