[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190729191511.GB2023@amd>
Date: Mon, 29 Jul 2019 21:15:12 +0200
From: Pavel Machek <pavel@....cz>
To: Chuhong Yuan <hslester96@...il.com>
Cc: "Rafael J . Wysocki" <rjw@...ysocki.net>,
Len Brown <len.brown@...el.com>, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/12] power: Replace strncmp with str_has_prefix
On Mon 2019-07-29 23:14:54, Chuhong Yuan wrote:
> strncmp(str, const, len) is error-prone.
> We had better use newly introduced
> str_has_prefix() instead of it.
>
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>
> ---
> kernel/power/hibernate.c | 8 ++++----
> kernel/power/main.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> index cd7434e6000d..49d4bfdb2b67 100644
> --- a/kernel/power/hibernate.c
> +++ b/kernel/power/hibernate.c
> @@ -1188,15 +1188,15 @@ static int __init resume_offset_setup(char *str)
>
> static int __init hibernate_setup(char *str)
> {
> - if (!strncmp(str, "noresume", 8)) {
> + if (str_has_prefix(str, "noresume")) {
> noresume = 1;
> - } else if (!strncmp(str, "nocompress", 10)) {
> + } else if (str_has_prefix(str, "nocompress")) {
> nocompress = 1;
Ok, old code is bad, too... but this makes the error visible. We do
not want "noresumenextmonday" to set noresume = 1, right?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)
Powered by blists - more mailing lists