linux-kernel - Re: [PATCH] h8300: Add missing symbol "BOOT_LINK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190730154906.GA18870@roeck-us.net>
Date:   Tue, 30 Jul 2019 08:49:06 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Yoshinori Sato <ysato@...rs.sourceforge.jp>
Cc:     uclinux-h8-devel@...ts.sourceforge.jp, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] h8300: Add missing symbol "BOOT_LINK_OFFSET"

On Wed, Jul 17, 2019 at 10:55:00PM +0900, Yoshinori Sato wrote:
> Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> ---
>  arch/h8300/Kconfig | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/h8300/Kconfig b/arch/h8300/Kconfig
> index ecfc4b4b6373..6974513b1ae9 100644
> --- a/arch/h8300/Kconfig
> +++ b/arch/h8300/Kconfig
> @@ -45,4 +45,7 @@ config NR_CPUS
>  	int
>  	default 1
>  
> +config BOOT_LINK_OFFSET
> +	hex	"zImage link offset"
> +

"hex" requires a default value. The above declaration generates
"CONFIG_BOOT_LINK_OFFSET=" in the configuration file, which is invalid
and can not be fixed with "make ARCH=h8300 olddefconfig". This in turn
results in "make" requesting a value when it encounters the symbol,
meaning that automated builds of h8300 images are no longer possible,
at least not without workarounds.

Guenter