linux-kernel - Re: [PATCH v2] rtl8192_init_priv_variable: null check is missing for kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190730164304.GA10640@kroah.com>
Date:   Tue, 30 Jul 2019 18:43:04 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     devel@...verdev.osuosl.org, kjlu@....edu,
        linux-kernel@...r.kernel.org,
        John Whitmore <johnfwhitmore@...il.com>, emamd001@....edu,
        Nishka Dasgupta <nishkadg.linux@...il.com>, smccaman@....edu,
        Colin Ian King <colin.king@...onical.com>
Subject: Re: [PATCH v2] rtl8192_init_priv_variable: null check is missing for
 kzalloc

On Tue, Jul 30, 2019 at 09:30:58AM -0500, Navid Emamdoost wrote:
> Allocation for priv->pFirmware may fail, so a null check is necessary.
> priv->pFirmware is accessed later in rtl8192_adapter_start. I added the
>  check and made appropriate changes to propagate the errno to the caller.
> 
> Update: fixed style errors

The "changelog" goes below the --- line, as is described in the kernel
documentation.

Also, please look at other patches for this driver, use the same prefix
for the subject line as those did.

v3 please?

thanks,

greg k-h