linux-kernel - Re: [PATCH -next] drm/rockchip: Make analogix_dp_atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190730170738.GR104440@art_vandelay>
Date:   Tue, 30 Jul 2019 13:07:38 -0400
From:   Sean Paul <sean@...rly.run>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     a.hajda@...sung.com, narmstrong@...libre.com,
        Laurent.pinchart@...asonboard.com, jonas@...boo.se,
        jernej.skrabec@...l.net, airlied@...ux.ie, daniel@...ll.ch,
        seanpaul@...omium.org, heiko@...ech.de,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH -next] drm/rockchip: Make analogix_dp_atomic_check static

On Tue, Jul 30, 2019 at 11:00:57PM +0800, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1151:5: warning:
>  symbol 'analogix_dp_atomic_check' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks for your patch, applied to drm-misc-next

Sean

> ---
>  drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index c82c7d5..f2f7f69 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1148,8 +1148,8 @@ analogix_dp_best_encoder(struct drm_connector *connector)
>  }
>  
>  
> -int analogix_dp_atomic_check(struct drm_connector *connector,
> -			     struct drm_atomic_state *state)
> +static int analogix_dp_atomic_check(struct drm_connector *connector,
> +				    struct drm_atomic_state *state)
>  {
>  	struct analogix_dp_device *dp = to_dp(connector);
>  	struct drm_connector_state *conn_state;
> -- 
> 2.7.4
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS