lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190730170835.GA20715@roeck-us.net>
Date:   Tue, 30 Jul 2019 10:08:35 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] watchdog: wdt977: Mark expected switch fall-through

On Mon, Jul 29, 2019 at 05:31:59PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: arm):
> 
> drivers/watchdog/wdt977.c: In function ‘wdt977_ioctl’:
>   LD [M]  drivers/media/platform/vicodec/vicodec.o
> drivers/watchdog/wdt977.c:400:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    wdt977_keepalive();
>    ^~~~~~~~~~~~~~~~~~
> drivers/watchdog/wdt977.c:403:2: note: here
>   case WDIOC_GETTIMEOUT:
>   ^~~~
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/wdt977.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/wdt977.c b/drivers/watchdog/wdt977.c
> index 567005d7598e..5c52c73e1839 100644
> --- a/drivers/watchdog/wdt977.c
> +++ b/drivers/watchdog/wdt977.c
> @@ -398,7 +398,7 @@ static long wdt977_ioctl(struct file *file, unsigned int cmd,
>  			return -EINVAL;
>  
>  		wdt977_keepalive();
> -		/* Fall */
> +		/* Fall through */
>  
>  	case WDIOC_GETTIMEOUT:
>  		return put_user(timeout, uarg.i);

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ