linux-kernel - Re: [PATCH] watchdog device drivers:pc87413_wdt: Rewriting of pc87413_wdt driver to utilize common watchdog interface (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jul 2019 17:26:01 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mark Balantzyan <mbalant3@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        wim@...ux-watchdog.org
Subject: Re: [PATCH] watchdog device drivers:pc87413_wdt: Rewriting of
 pc87413_wdt driver to utilize common watchdog interface (fwd)

On 7/29/19 4:17 PM, Mark Balantzyan wrote:
> 
> 
> ---------- Forwarded message ----------
> Hi all, sorry for the duplicate message Guenter, wanted to be sure my
> message is transferred:
> 
> Thank you for your reply, Guenter! Sorry there were issues applying the
> patch, I used git format-patch to produce the patch and pasted the main
> contents into a plaintext email client so I thought it would work..
> 
> May I please request clarification on which functions are no longer needed?
> 

All functions dealing with file accesses directly. open, read, write, ioctl.
Don't you see that when you compile the code ?

> Sorry about forgetting about that last misc_deregister(). Will do more
> tests, if that’s alright with you.
> 
> In effect, may it be best to start the watchdog from the “init” function?
> 
The watchdog should only be started from its start function, when it is
opened. There are alternatives, such as informing the watchdog core that
the watchdog has been started even though it is not closed.

I am repeating myself here, since I don't recall an answer: Do you have
the hardware ? If not, it does not make sense to continue this work; it
is too risky to make all those changes without testing them on real
hardware (or, at the very least, with qemu, but qemu doesn't support
this chip).

Thanks,
Guenter