linux-kernel - Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea83e4d6227b70ae4731c2bfcd727e3afeac3bf8.camel@kernel.crashing.org>
Date:   Tue, 30 Jul 2019 13:37:50 -0700
From:   Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:     Kees Cook <keescook@...omium.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        PowerPC <linuxppc-dev@...ts.ozlabs.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Linux kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch
 fall-through

On Tue, 2019-07-30 at 10:07 -0700, Kees Cook wrote:
> 
> > Why do we think it's an expected fall through? I can't really
> > convince
> > myself from the surrounding code that it's definitely intentional.
> 
> Yeah, good question. Just now when I went looking for who
> used SMU_I2C_TRANSFER_COMBINED, I found the only caller in
> arch/powerpc/platforms/powermac/low_i2c.c and it is clearly using a
> fall-through for building the command for "stdsub" and "combined",
> so I think that's justification enough:

Yes, sorry for the delay, the fall through is intentional.

Cheers,
Ben.