linux-kernel - Re: [PATCH] idr: Document calling context for IDA APIs mustn't use locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d40b422.1c69fb81.204e.b4d8@mx.google.com>
Date:   Tue, 30 Jul 2019 14:18:25 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Tri Vo <trong@...roid.com>, linux-doc@...r.kernel.org,
        Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH] idr: Document calling context for IDA APIs mustn't use locks

Quoting Matthew Wilcox (2019-07-30 14:12:50)
> On Tue, Jul 30, 2019 at 02:07:52PM -0700, Stephen Boyd wrote:
> > The documentation for these functions indicates that callers don't need
> > to hold a lock while calling them, but that documentation is only in one
> > place under "IDA Usage". Let's state the same information on each IDA
> > function so that it's clear what the calling context requires.
> > Furthermore, let's document ida_simple_get() with the same information
> > so that callers know how this API works.
> 
> I don't want people to use ida_simple_get() any more.  Use ida_alloc()
> instead.

Fair enough. I'll document it as deprecated in another patch.

> 
> > - * Context: Any context.
> > + * Context: Any context. It is safe to call this function without
> > + * synchronisation in your code.
> 
> I prefer "without locking" to "without synchronisation" ...
> 

Ok. Resending shortly.