linux-kernel - Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch fall-through

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190730144526.3088aad4@canb.auug.org.au>
Date:   Tue, 30 Jul 2019 14:45:26 +1000
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     PowerPC <linuxppc-dev@...ts.ozlabs.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Kees Cook <keescook@...omium.org>,
        Linux kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/macintosh/smu.c: Mark expected switch
 fall-through

Hi all,

On Tue, 30 Jul 2019 14:37:04 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:
>
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: powerpc):
> 
> drivers/macintosh/smu.c: In function 'smu_queue_i2c':
> drivers/macintosh/smu.c:854:21: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    cmd->info.devaddr &= 0xfe;
>    ~~~~~~~~~~~~~~~~~~^~~~~~~
> drivers/macintosh/smu.c:855:2: note: here
>   case SMU_I2C_TRANSFER_STDSUB:
>   ^~~~
> 
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Gustavo A. R. Silva <gustavo@...eddedor.com>
> Cc: Kees Cook <keescook@...omium.org>
> Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>

Fixes: 0365ba7fb1fa ("[PATCH] ppc64: SMU driver update & i2c support")

Sorry, forgot :-)
-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped