linux-kernel - Re: [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f378f2dc-6a74-35cc-a380-2eba0ebcf004@ti.com>
Date:   Tue, 30 Jul 2019 09:28:46 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Keerthy <j-keerthy@...com>, <jsarha@...com>
CC:     <airlied@...ux.ie>, <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <t-kristo@...com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpu: drm/tilcdc: Fix switch case fallthrough

On 17/07/2019 08:09, Keerthy wrote:
> Fix the below build warning/Error
> 
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c: In function ‘tilcdc_crtc_set_mode’:
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:384:8: error: this statement may fall
> through [-Werror=implicit-fallthrough=]
>      reg |= LCDC_V2_TFT_24BPP_UNPACK;
>      ~~~~^~~~~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:386:3: note: here
>     case DRM_FORMAT_BGR888:
>     ^~~~
> cc1: all warnings being treated as errors
> make[5]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1
> make[4]: *** [drivers/gpu/drm/tilcdc] Error 2
> make[4]: *** Waiting for unfinished jobs....
> 
> Fixes: f6382f186d2982750 ("drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()")
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
>   drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...com>

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki