linux-kernel - Re: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <877e80ne9n.fsf@codeaurora.org>
Date:   Tue, 30 Jul 2019 11:00:04 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2

"Gustavo A. R. Silva" <gustavo@...eddedor.com> writes:

> On 7/27/19 1:08 PM, Linus Torvalds wrote:
>
>> 
>> Ok, I have tried re-pulling and if it passes my build tests cleanly
>> I'll push the result out.
>> 
>
> Awesome. :)

BTW, now when using ccache 3.2.4 (which I admit is an old release from
2015 but included still in Ubuntu 16.04) I see a lot of fall-through
warnings when building the kernel. I reported this to Gustavo before but
didn't find the time to answer back to his extra questions, sorry about
that.

I did investigate the issue at the time and IIRC it was because ccache
strips away the comments (including the fallback comments) before
feeding the source file to the compiler. Apparently newer ccache
versions has a setting to avoid that but I have not tried upgrading yet.
But anyone using old ccache should definitely upgrade.

-- 
Kalle Valo