linux-kernel - Re: [PATCH] drivers: net: wireless: rsi: return explicit error values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k1c0lybm.fsf@codeaurora.org>
Date:   Tue, 30 Jul 2019 11:29:49 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Enrico Weigelt\, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, amitkarwar@...il.com,
        siva8118@...il.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] drivers: net: wireless: rsi: return explicit error values

"Enrico Weigelt, metux IT consult" <info@...ux.net> writes:

> From: Enrico Weigelt <info@...ux.net>
>
> Explicitly return constants instead of variable (and rely on
> it to be explicitly initialized), if the value is supposed
> to be fixed anyways. Align it with the rest of the driver,
> which does it the same way.
>
> Signed-off-by: Enrico Weigelt <info@...ux.net>
> ---
>  drivers/net/wireless/rsi/rsi_91x_sdio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

The prefix should be just "rsi:", I'll fix that.

-- 
Kalle Valo