linux-kernel - Re: [RFC 3/9] workqueue: require CPU hotplug read exclusion for apply_workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190730015343.lgj4hxejorofibmo@ca-dmjordan1.us.oracle.com>
Date:   Mon, 29 Jul 2019 21:53:43 -0400
From:   Daniel Jordan <daniel.m.jordan@...cle.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Daniel Jordan <daniel.m.jordan@...cle.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC 3/9] workqueue: require CPU hotplug read exclusion for
 apply_workqueue_attrs

On Mon, Jul 29, 2019 at 12:47:21PM -0700, Tejun Heo wrote:
> On Thu, Jul 25, 2019 at 05:24:59PM -0400, Daniel Jordan wrote:
> > Change the calling convention for apply_workqueue_attrs to require CPU
> > hotplug read exclusion.
> > 
> > Avoids lockdep complaints about nested calls to get_online_cpus in a
> > future patch where padata calls apply_workqueue_attrs when changing
> > other CPU-hotplug-sensitive data structures with the CPU read lock
> > already held.
> > 
> > Signed-off-by: Daniel Jordan <daniel.m.jordan@...cle.com>
> 
> Acked-by: Tejun Heo <tj@...nel.org>

Thanks, Tejun!