linux-kernel - Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on orig_egr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85e79b89-9d48-8aa2-b96f-7d30a5716d59@canonical.com>
Date:   Tue, 30 Jul 2019 12:37:09 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Petr Machata <petrm@...lanox.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, Ido Schimmel <idosch@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] mlxsw: spectrum_ptp: fix duplicated check on
 orig_egr_types

On 30/07/2019 12:12, Petr Machata wrote:
> 
> Petr Machata <petrm@...lanox.com> writes:
> 
>> Colin King <colin.king@...onical.com> writes:
>>
>>> From: Colin Ian King <colin.king@...onical.com>
>>>
>>> Currently there is a duplicated check on orig_egr_types which is
>>> redundant, I believe this is a typo and should actually be
>>> orig_ing_types || orig_egr_types instead of the expression
>>> orig_egr_types || orig_egr_types.  Fix this.
>>
>> Good catch, yes, there's a typo. Thanks for the fix!
>>
>>> Addresses-Coverity: ("Same on both sides")
>>> Fixes: c6b36bdd04b5 ("mlxsw: spectrum_ptp: Increase parsing depth when PTP is enabled")
>>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>>
>> Reviewed-by: Petr Machata <petrm@...lanox.com>
> 
> I see that there is an identical problem in the code one block further.
> Can you take care of that as well, please? Or should I do it?
> 
I'll sort that out too