linux-kernel - Re: [PATCH] ASoC: ti: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190730105528.GA27548@bitmer.com>
Date:   Tue, 30 Jul 2019 13:55:28 +0300
From:   Jarkko Nikula <jarkko.nikula@...mer.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Peter Ujfalusi <peter.ujfalusi@...com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, alsa-devel@...a-project.org,
        linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kees Cook <keescook@...omium.org>
Subject: Re: [PATCH] ASoC: ti: Mark expected switch fall-throughs

On Mon, Jul 29, 2019 at 05:15:34PM -0500, Gustavo A. R. Silva wrote:
> Mark switch cases where we are expecting to fall through.
> 
> This patch fixes the following warning (Building: arm):
> 
> sound/soc/ti/n810.c: In function ‘n810_ext_control’:
> sound/soc/ti/n810.c:48:10: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    line1l = 1;
>    ~~~~~~~^~~
> sound/soc/ti/n810.c:49:2: note: here
>   case N810_JACK_HP:
>   ^~~~
> 
> sound/soc/ti/rx51.c: In function ‘rx51_ext_control’:
> sound/soc/ti/rx51.c:57:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    hs = 1;
>    ~~~^~~
> sound/soc/ti/rx51.c:58:2: note: here
>   case RX51_JACK_HP:
>   ^~~~
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  sound/soc/ti/n810.c | 1 +
>  sound/soc/ti/rx51.c | 1 +
>  2 files changed, 2 insertions(+)
> 
Acked-by: Jarkko Nikula <jarkko.nikula@...mer.com>