linux-kernel - Re: [PATCH v4 01/14] crypto: caam/qi - fix error handling in ERN handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4445B5459C40E99E386005F88CDC0@VI1PR04MB4445.eurprd04.prod.outlook.com>
Date:   Tue, 30 Jul 2019 12:08:55 +0000
From:   Iuliana Prodan <iuliana.prodan@....com>
To:     Herbert Xu <herbert@...dor.apana.org.au>,
        Horia Geanta <horia.geanta@....com>,
        Aymen Sghaier <aymen.sghaier@....com>
CC:     "David S. Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>
Subject: Re: [PATCH v4 01/14] crypto: caam/qi - fix error handling in ERN
 handler

On 7/30/2019 2:06 PM, Iuliana Prodan wrote:
> From: Horia Geantă <horia.geanta@....com>
> 
> ERN handler calls the caam/qi frontend "done" callback with a status
> of -EIO. This is incorrect, since the callback expects a status value
> meaningful for the crypto engine - hence the cryptic messages
> like the one below:
> platform caam_qi: 15: unknown error source
> 
> Fix this by providing the callback with:
> -the status returned by the crypto engine (fd[status]) in case
> it contains an error, OR
> -a QI "No error" code otherwise; this will trigger the message:
> platform caam_qi: 50000000: Queue Manager Interface: No error
> which is fine, since QMan driver provides details about the cause of
> failure
> 
> Cc: <stable@...r.kernel.org> # v5.1+
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend support")
> Signed-off-by: Horia Geantă <horia.geanta@....com>
> ---
Reviewed-by: Iuliana Prodan <iuliana.prodan@....com>

Thanks,
Iulia