lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Jul 2019 19:35:04 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Mark Balantzyan <mbalant3@...il.com> Cc: wim@...ux-watchdog.org, linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org, andrianov@...ras.ru Subject: Re: [PATCH 3/4] watchdog device drivers:pc87413_wdt: Tidying up conversion of pc87413_wdt driver to common watchdog interface, removal of some stray nowayout parameters On 7/29/19 7:15 PM, Mark Balantzyan wrote: > There is a potential for the variable swc_base_addr in the call chain of the > driver initialization function (init) to be used before initialization. This > brought up the need for, by rewriting the driver to use the common watchdog > interface, ensuring to have all resources in place. This patch addresses this > need by rewriting into common watchdog interface utilization for the driver. > > Signed-off-by: Mark Balantzyan <mbalant3@...il.com> > > --- > drivers/watchdog/pc87413_wdt.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c > index a9070a22..bc6c4e19 100644 > --- a/drivers/watchdog/pc87413_wdt.c > +++ b/drivers/watchdog/pc87413_wdt.c > @@ -392,9 +392,3 @@ module_param(timeout, int, 0); > MODULE_PARM_DESC(timeout, > "Watchdog timeout in minutes (default=" > __MODULE_STRING(DEFAULT_TIMEOUT) ")."); > - > -module_param(nowayout, bool, 0); > -MODULE_PARM_DESC(nowayout,watchdog_set_nowayout > - "Watchdog cannot be stopped once started (default=" > - __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); > - > Why would you no longer want this module parameter ? You should keep it and call watchdog_set_nowayout(wdev, nowayout); in the probe function. Guenter
Powered by blists - more mailing lists