linux-kernel - Re: [PATCH] cifs: remove redundant assignment to variable rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f562159-8118-f4a5-9e00-c82cf0841fd5@canonical.com>
Date:   Wed, 31 Jul 2019 16:54:31 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Aurélien Aptel <aaptel@...e.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     samba-technical@...ts.samba.org, Steve French <sfrench@...ba.org>,
        kernel-janitors@...r.kernel.org, linux-cifs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc

On 31/07/2019 16:34, Aurélien Aptel wrote:
> "Dan Carpenter" <dan.carpenter@...cle.com> writes:
>> You're just turning off GCC's static analysis (and introducing false
>> positives) when you do that.  We have seen bugs caused by this and never
>> seen any bugs prevented by this style.
> 
> You've never seen bugs prevented by initializing uninitialized
> variables? Code can change overtime and I don't think coverity is
> checked as often as it could be, meaning the var could end up being used
> while uninitialized in the future.

gcc/clang should pick up uninitialized vars at compile time. also I run
coverity daily on linux-next.

Colin

> 
> Anyway I won't die on this hill, merge this if you prefer.
> 
> Cheers,
>